Skip to content

fix(report): update regex pattern to include more separator lines#187

Merged
Rubilmax merged 1 commit intoRubilmax:mainfrom
penandlim:john/updateSeparatorRegex
Jan 20, 2025
Merged

fix(report): update regex pattern to include more separator lines#187
Rubilmax merged 1 commit intoRubilmax:mainfrom
penandlim:john/updateSeparatorRegex

Conversation

@penandlim
Copy link
Contributor

@penandlim penandlim commented Jan 17, 2025

The reportSeparatorRegex is missing a couple of new separators.

This is what the --gas-report output currently looks like for forge 0.3.0 (55badd4 2025-01-17T00:21:10.590438000Z)

Suite result: ok. 96 passed; 0 failed; 0 skipped; finished in 352.58s (3137.75s CPU time)

╭----------------------------------------------------------------------------+-----------------+-------+--------+-------+---------╮
| dependencies/euler-price-oracle-1/src/EulerRouter.sol:EulerRouter Contract |                 |       |        |       |         |
+=================================================================================================================================+
| Deployment Cost                                                            | Deployment Size |       |        |       |         |
|----------------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| 752721                                                                     | 3467            |       |        |       |         |
|----------------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
|                                                                            |                 |       |        |       |         |
|----------------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| Function Name                                                              | Min             | Avg   | Median | Max   | # Calls |
|----------------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| getQuote                                                                   | 2375            | 4471  | 2377   | 8877  | 32821   |
|----------------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| govSetConfig                                                               | 29030           | 45203 | 48930  | 49146 | 1914    |
╰----------------------------------------------------------------------------+-----------------+-------+--------+-------+---------╯

This PR updates the regex so it includes these separator lines as well.
+=======+
| |

Fixes #186

@penandlim penandlim mentioned this pull request Jan 17, 2025
Closed
@Rubilmax
Copy link
Owner

Rubilmax commented Jan 20, 2025

Thank you for this! It looks like they changed the format again (because this separator was a simple line at the time I fixed the issue)

Let me double check this regex wrt backward compatibility, and I'll approve that!

@Rubilmax Rubilmax merged commit 4cdca35 into Rubilmax:main Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rubilmax Rubilmax Rubilmax approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Foundry's update on gas report output breaks compatibility

2 participants

@penandlim @Rubilmax